feat: sign release artifacts with cosign #5793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
commented
May 11, 2025
| @@ -87,6 +87,16 @@ release: | |||
|
|
|||
| For key updates, see the [changelog](https://golangci-lint.run/product/changelog/#{{ .Major }}{{ .Minor }}{{ .Patch }}). | |||
|
|
|||
| signs: | |||
There was a problem hiding this comment.
Non-CI goreleaser release runs should likely be done with --skip sign in order to not break after we add this.
scop
commented
May 11, 2025
| @@ -87,6 +87,16 @@ release: | |||
|
|
|||
| For key updates, see the [changelog](https://golangci-lint.run/product/changelog/#{{ .Major }}{{ .Minor }}{{ .Patch }}). | |||
|
|
|||
| signs: | |||
| - signature: ${artifact}.cosign.bundle | |||
| cmd: cosign | |||
There was a problem hiding this comment.
I guess some docs how to verify downloads with cosign would not hurt. But we don't have any for verifying the sha256sums either, so not sure. #5806 contains changes for verifying in the installer script.
scop
force-pushed
the
feat/cosign-artifacts
branch
from
12b2fc0 to
6898794
Compare
ldez
added
area: install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample results in my fork (do not mind the changelog, scroll down to assets): https://github.com/scop/golangci-lint/releases/tag/v0.0.0
Fixes #2462